Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vertical scroll not working in chat #18

Closed
wants to merge 2 commits into from
Closed

Fix Vertical scroll not working in chat #18

wants to merge 2 commits into from

Conversation

athrael-soju
Copy link

@athrael-soju athrael-soju commented Sep 25, 2023 •
edited

Problem

Fixes #16

Solution

Removed justify-end

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (Introcuded environment variables)

Test Plan

Simply add enough messages, or minimize the window to show the scrollbar.

@athrael-soju athrael-soju changed the title Remove justify-end Fix Vertical scroll not working in chat Sep 25, 2023
@athrael-soju athrael-soju mentioned this pull request Sep 25, 2023
Open
2 tasks
@athrael-soju athrael-soju marked this pull request as ready for review September 25, 2023 12:14
harounansari-cj
harounansari-cj approved these changes Sep 25, 2023
View reviewed changes
Copy link

@harounansari-cj harounansari-cj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A video of it working would be great

@athrael-soju athrael-soju mentioned this pull request Oct 9, 2023
Merged
@athrael-soju
Copy link
Author

A video of it working would be great

https://watch.screencastify.com/v/8fhBeKRDn60epupEH8Fr

@edmondtam1
Copy link

Came here looking for this fix, thank you!

One comment: you might be using a personal linter, leading to double quotes " becoming single '. Other than that, LGTM!

@athrael-soju athrael-soju closed this by deleting the head repository Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harounansari-cj harounansari-cj harounansari-cj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Vertical scroll not working in chat
3 participants
@athrael-soju @edmondtam1 @harounansari-cj