Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bright and normal colours are identical #8

Open
ojdo opened this issue Aug 26, 2021 · 4 comments
Open

Bright and normal colours are identical #8

ojdo opened this issue Aug 26, 2021 · 4 comments

Comments

@ojdo
Copy link

ojdo commented Aug 26, 2021

I very much enjoy the overall look of this colour scheme, but had to disable it due to normal and bright colours being identical. This correcting commit 00eaad3 makes me believe that this is not accidental but intentional. Is there a chance to have all 16 colours distinct?

Breaking for me is the mail view in MUA alot, for which all mail header lines become invisible with SpaceDuck active.

@pineapplegiant
Copy link
Owner

Do you mind providing a screenshot? I can totally change those colors, I truthfully don’t know how the bright colors work. The purple and yellow was the only intentional change. I’ll see if I can come up with something good

@ojdo
Copy link
Author

ojdo commented Aug 29, 2021

Here is a pair of screenshots with the difference in appearance between Campbell and SpaceDuck:

Campbell

grafik

SpaceDuck

grafik

And just for reference, why it occurs in alot: its default theme uses dark and light gray for foreground/background of header_value (i.e. the field contents).

@kmuncie
Copy link

kmuncie commented Feb 20, 2022

I would agree, there should be a distinction between normal and bright colors. I ended up adjusting the Windows Terminal color scheme in order to resolve the issues I was having. Here is the config I ended on and some examples from before and after through neofetch.

        {
            "name": "SpaceDuck",
            "cursorColor": "#f2ce00",
            "selectionBackground": "#f2ce00",
            "foreground": "#ecf0c1",
            "background": "#0f111b",
            "black": "#000000",
            "red": "#d36240",
            "green": "#5ccc96",
            "yellow": "#b3a1e6",
            "blue": "#6d3c8a",
            "purple": "#c0aa2e",
            "cyan": "#00a3cc",
            "white": "#c9cca9",
            "brightBlack": "#686f9a",
            "brightRed": "#e33400",
            "brightGreen": "#51eea2",
            "brightYellow": "#9d79ff",
            "brightBlue": "#9630d1",
            "brightPurple": "#f2ce00",
            "brightCyan": "#19c5f0",
            "brightWhite": "#fafce0"
        }

Repo color scheme:
before

My custom color scheme changes:
after2

@pineapplegiant
Copy link
Owner

This looks pretty good. I'll have to test and add this in. If it works, it'd be good to update all the other configs as well. I've heard some complaints from others regarding this issue. Thanks for this @kmuncie ! 🚀 🦆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants