-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement]: pimcore:bundle:install should no-op if a bundle is already installed #17029
Comments
Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding. |
Improvement description
Currently, when running
bin/console pimcore:bundle:install
with a bundle that is already installed, an error is generated:[ERROR] Bundle BundleName can not be installed.
This is a problem in Docker-based and continuous integration/deployment scenarios, as we regularly run (and re-run) such commands as part of the init operations of our applications. In order to workaround this issue, we have to use the--fail-without-error
flag (which may ignore legitimate problems with the bundle installation), or choose to ignore errors altogether in the init script (e.g. by not settingset -e
in the entrypoint of a container, which is not ideal as this will cause the script to skip other legitimate errors)In my view, trying to install a bundle that is already installed is not an error situation, and the default behaviour of this command should be to no-op and continue without error. Alternatively, if the behaviour of the current command is desirable, I suggest adding an optional flag to the command to ignore bundles that are already installed.
The text was updated successfully, but these errors were encountered: