New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pico's Markdown Filter doesn't throw errors #603
Comments
We can't enable strict typing everywhere without major BC breaks (likely Pico 4.0), so we're doing this on a best-effort basis. Fixes #603
I just added PHP strict typing, passing an array to Pico's |
Sorry, I've been meaning to get back to you on these issues. I suddenly found myself kind of busy with yet another Pico related project (besides just trying to get all the themes updated). Yeah, I wasn't necessarily looking for Markdown errors to be noted... just the fact that it could outright fail entirely without feedback seemed unintuitive. I'm probably the only person who will ever manage to feed it the wrong data type though. 😂 |
Mentioned in #600.
Pico's markdown filter doesn't throw any errors. This is a different behavior to Twig's built in filters, which are very verbose and will print errors directly on the page if used incorrectly.
I accidentally fed the markdown filter an array a couple times and it just silently failed. 🤦🏻♀️
No idea if Pico's other filters are like this or not, but it's probably worth investigating.
The text was updated successfully, but these errors were encountered: