Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing Enter in Reverse 1 migration? [y/N] still leads to reversing. #991

Closed
metakot opened this issue May 20, 2024 · 2 comments · Fixed by #992
Closed

Pressing Enter in Reverse 1 migration? [y/N] still leads to reversing. #991

metakot opened this issue May 20, 2024 · 2 comments · Fixed by #992

Comments

@metakot
Copy link

metakot commented May 20, 2024

When undoing the migration, pressing Enter after the prompt Reverse 1 migration? [y/N] still undoing it regardless of the default N behavior.
@dantownsend
Copy link
Member

Ah, weird. I just tried it and I can see what you mean.

Screenshot 2024-05-21 at 10 58 38

I'll have a look at the code.

@dantownsend
Copy link
Member

dantownsend commented May 21, 2024 •
edited

I've figured out the problem. Basically this:

>>> '' in 'yY'
True

I think this is quite unintuitive - I would have expected False.

@dantownsend dantownsend mentioned this issue May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

991 Pressing Enter in Reverse 1 migration? [y/N] still leads to reversing. piccolo-orm/piccolo
2 participants
@dantownsend @metakot