New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gravity doesn't exit if there is a storage problem. #5244
Comments
So, gravity doesn't actually complete, the old database is still in use? You're mainly saying that the display is incorrect? And can you do another debug run, the token URL has expired. |
yes
|
Okay, I'll take a look in a bit. |
Versions
Pi-hole version is v5.16.2 (Latest: v5.16.2)
AdminLTE version is v5.19 (Latest: v5.19)
FTL version is update/dnsmasq vDev-879708d (Latest: v5.22)
Platform
Raspberry pi 3B
Linux raspberrypi 6.1.19-v7+ #1637 SMP Tue Mar 14 11:04:52 GMT 2023 armv7l GNU/Linux
Expected behavior
exit 1 on error, generate warning message
Actual behavior / bug
gravity continues, regardless problem
Steps to reproduce
using GRAVITY_TMPDIR=/home/pi/tmp (setupVars.conf)
fstab entry for the mount point, configured to small (on purpose)
sudo mount /home/pi/tmp
run pihole -g
error message (repeats after every list as soon space runs out, thus multiple messages):
final message:
gravity completes (no exit 1), dashboard says "adlists updated 00:05 (hh:mm) ago, but actually using old database (updated field in info table is modified, regardless of success)
Debug Token
debug has been created after changing the TMPFS size, and build gravity with success.
https://tricorder.pi-hole.net/FblkfEu9/
Screenshots
Additional context
trying to run gravity.sh on TMPFS, the to save the SD card, works fine, unless available TMPFS storage is to small, current adlists require 96Mb
I think this line:
needs error checking.
The text was updated successfully, but these errors were encountered: