-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host Header gets overwritten whens setting the URL #213
Comments
jimktrains
added a commit
to MSQC/php-vcr
that referenced
this issue
Oct 4, 2017
renatomefi
pushed a commit
to MSQC/php-vcr
that referenced
this issue
Oct 18, 2017
renatomefi
pushed a commit
to MSQC/php-vcr
that referenced
this issue
Oct 18, 2017
renatomefi
added a commit
that referenced
this issue
Oct 18, 2017
Issue #213. Don't set Host header in setUrl if already set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a host header is set, either from a cassette or by hand, and then the URL is set (as is done in the constructor), the
setURL
method will overwrite theHost
header. This behavior is ill-advised and can cause issues when theHost
header from curl contains a port, or if they were made to be different for a specific reason.The text was updated successfully, but these errors were encountered: