-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please support Non-English map in Place #789
Projects
Comments
kkovaletp
added
feature
A new idea or feature
UI
Related to the frontend web ui written in Javascript
labels
May 4, 2024
kkovaletp
added a commit
to kkovaletp/photoview
that referenced
this issue
May 13, 2024
This is a solution of photoview#789. The language of the map in Place will be set to the same as the UI. If the UI language is NOT supported by Mapbox, then the English map will be provided. This is a new pull request of setting the map language to UI language, and I commit it to a new branch other than master. The old one will be closed soon. As per the comment in the old pull request photoview#790, I deleted the settings of zoom and center and deleted the setting of projection, which means the map language cannot be changed. I have looked at the commit setting the projection, it said "chore: add mapbox globe view", so I guess the committer just wants to show the mapbox with the whole world map initially. But I think maybe he or she doesn't know what the projection really means, in fact, global projection just makes a spherical map. So, I add zoom: 1 to show the mapbox with the whole world map initially. --------- Co-authored-by: WindLi001 <[email protected]>
kkovaletp
changed the title
Please supports Non-English map in Place
Please support Non-English map in Place
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Now the map in Place is always in English, and it isn't so good for the user who doesn't speak English. For example, me :-).
Since supporting Non-English website language, I think Non-English map should be provided too.
Describe the solution you'd like
I think manual or automatic configuring the map language is a good idea.
Manual configuring the map language
Configuring the map language in Setting, just like configuring the website language.
Automatic configuring the map language
Set the map language to the same one of the website language in Setting.
I'm not so familiar to the Mapbox API. But according to some pages found on Internet, Mapbox provides the API to set the language of map.
Describe alternatives you've considered
None.
Additional context
None.
The text was updated successfully, but these errors were encountered: