Splitting the core.phel #160
Locked
Chemaclass
started this conversation in
Ideas
Replies: 4 comments 4 replies
-
I will have a look if there is a way to split the files but keep them under the same namespace. Then we have both advantages. |
Beta Was this translation helpful? Give feedback.
1 reply
-
I created an issue for that #169 |
Beta Was this translation helpful? Give feedback.
0 replies
-
@Chemaclass @jenshaase can we close this? |
Beta Was this translation helpful? Give feedback.
3 replies
-
This was done (#169) but undone later when working on the compile command (#293). So I will mark this as |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
What do you think about grouping and splitting the
core.phel
into multiple files?I am not sure right now about how exactly, but I while reading the
core.phel
I realise that this grouping is done somehow by the comment delimiters such as:These are all of them:
There are 16 of them. It makes sense to think about splitting them, same as we already did for the
http.phel
,html.phel
andtest.phel
.As an idea, maybe we could keep all basics stuff in the "core", and try to group the rest on their own files?
I am not so keen on having 16 different files and that you need to require all of them everywhere because you will likely use every function... On the other hand, I like the idea that you will require the files that you really need, so you don't waste performance "requiring and parsing" stuff that you don't really need. And not only performance, but you will also group every function within their context, so the maintainability of each file will be easier in my opinion.
What do you think?
Beta Was this translation helpful? Give feedback.
All reactions