Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the name of the service token in application access logs #114

Open
nimish-ks opened this issue Nov 14, 2023 · 3 comments
Open

Print the name of the service token in application access logs #114

nimish-ks opened this issue Nov 14, 2023 · 3 comments
Assignees
Labels
backend enhancement New feature or request frontend Change in frontend code

Comments

@nimish-ks
Copy link
Member

Is your feature request related to a problem?

image

Currently all service tokens are displayed as 馃攽 Service token which makes it hard to trace access.

Describe the solution you'd like

image

  1. Print the name of the actual service used to access secrets in the logs
  2. Provide a link to similar to View this secret to view the service token.

Describe alternatives you've considered

Additional context

@nimish-ks nimish-ks added enhancement New feature or request good first issue Good for newcomers frontend Change in frontend code typescript Pull requests that update Typescript code labels Nov 14, 2023
@Dhoni77
Copy link

Dhoni77 commented Nov 14, 2023

Hi @nimish-ks I would like to work on this

@nimish-ks
Copy link
Member Author

nimish-ks commented Nov 14, 2023

@Dhoni77 All yours! Feel free to reach out to us on slack if you need any help / additional context -- https://slack.phase.dev

@rohan-chaturvedi
Copy link
Member

rohan-chaturvedi commented Nov 14, 2023

@Dhoni77 Here's some more context on implementing this:
The SecretEvent model is what we use to track CRUD changes to Secrets:

class SecretEvent(models.Model):

As you can see, there's a user foreign key. If this user key is null, we assume this event was created by a service token. Instead, we need to create an additional, nullable 'token' foreign key for the Service Token model:

class ServiceToken(models.Model):

Then, we'll need to handle the following:

As Nimish, said, feel free to join our Slack if you'd like any more context or have any questions!

@rohan-chaturvedi rohan-chaturvedi added backend and removed typescript Pull requests that update Typescript code good first issue Good for newcomers labels Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request frontend Change in frontend code
Projects
None yet
Development

No branches or pull requests

3 participants