Option ‘Pharo Light’ for setting ‘User interface theme’ cannot be saved to disk

[Rinzwind]

Scenario:

• Using Pharo Launcher, create and launch a new Pharo 13 image
• In the Settings Browser, change ‘User interface theme’ from ‘DarkBlue’ to ‘Pharo Light’
• Open a context menu on the setting and select ‘Save to disk’ (1.png)
• Close the image and delete it in Pharo Launcher
• Create and launch another new Pharo 13 image

The new image unexpectedly does not apply the ‘Pharo Light’ theme (2.png).

Version used: Pharo 13 build 106.

1.png:

2.png:

[Rinzwind]

This is because the setting value doesn’t actually get saved: it gets filtered out in #store on SettingsStonWriter because ‘Pharo Light’ is the default value.

The following should probably all use the same theme:

pharo/src/Polymorph-Widgets/UITheme.class.st

Lines 161 to 163 in 53c363d

	UITheme class >> standardThemeClass [
	^ PharoLightTheme
	]

pharo/src/Polymorph-Widgets/UITheme.class.st

Lines 79 to 81 in 53c363d

	^Current ifNil: [
	Current := PharoLightTheme newDefault.
	Current ]

pharo/src/Settings-Polymorph/PolymorphSystemSettings.class.st

Line 33 in 53c363d

default: (Smalltalk at: #PharoLightTheme);

pharo/src/BaselineOfMorphic/BaselineOfMorphic.class.st

Line 306 in 53c363d

PharoLightTheme beCurrent.

pharo/src/BaselineOfIDE/BaselineOfIDE.class.st

Line 301 in 53c363d

DarkBlueTheme beCurrent.