Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated references of SycMethodNameEditorPresenter to StMethodNameEditorPresenter #16816

Open
wants to merge 6 commits into
base: Pharo13
Choose a base branch
from
Open

Migrated references of SycMethodNameEditorPresenter to StMethodNameEditorPresenter #16816

wants to merge 6 commits into from
+30 −523

Conversation

matburnx
Copy link
Contributor

Fix #16795
Added Refactoring-UI as dependency in BaselineOfQA

Shouldn't SycMethodNameEditorPresenter and its tests be deleted now?

@matburnx
Migrated references from SycMethodNameEditorPresenter to `StMethodN…
cfb4f24 
…ameEditorPresenter`

Added `Refactoring-UI` as dependecy in `BaselineOfQA`
@MarcusDenker
Copy link
Member

Full image load fails with:

MetacelloNotification: Loaded -> BaselineOfQA --- unresolved
Error: Name not found: Refactoring-UI
MetacelloVersionSpec(Object)>>error:
[ ^ self error: 'Name not found: ' , aString ] in MetacelloVersionSpec>>resolveToLoadableSpec:forMap:packages: in Block: [ ^ self error: 'Name not found: ' , aString ]
[

@MarcusDenker MarcusDenker added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Jun 28, 2024
@matburnx
Copy link
Contributor Author

I think it's good now.

@hernanmd
Copy link
Contributor

I think it's good now.

I didn't see it in the changes, but is SycMethodNameEditorPresenter now removed in the PR?
(since it shouldn't be referenced anymore, it would be safe to remove)

@matburnx
Copy link
Contributor Author

matburnx commented Jul 1, 2024

SycMethodNameEditorPresenter is now deleted.

@hernanmd hernanmd requested a review from jecisc July 3, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jecisc jecisc Awaiting requested review from jecisc

Assignees
No one assigned
Labels
Status: Need more work The issue is nearly ready. Waiting some last bits.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StMethodNameEditorPresenter and SycMethodNameEditorPresenter 84% of similarity
3 participants
@matburnx @MarcusDenker @hernanmd