Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StMethodNameEditorPresenter and SycMethodNameEditorPresenter 84% of similarity #16795

Open
hernanmd opened this issue Jun 20, 2024 · 0 comments · May be fixed by #16816
Open

StMethodNameEditorPresenter and SycMethodNameEditorPresenter 84% of similarity #16795

hernanmd opened this issue Jun 20, 2024 · 0 comments · May be fixed by #16816

Comments

@hernanmd
Copy link
Contributor

Class implementations are almost identical (the remaining differences are due to StMethodNameEditorPresenter being a refactored version of SycMethodNameEditorPresenter)

  • SycMethodNameEditorPresenter from SystemCommands-RefactoringSupport.
  • StMethodNameEditorPresenter from Refactoring-UI.

Proposal

There are 19 references to SycMethodNameEditorPresenter.

Replacing all these references to StMethodNameEditorPresenter would not significantly impact them because they are in packages that already depend on Refactoring-UI. The exception is NautilusRefactoring>>handleMethodNameRequest:, which would need a new dependency specification to Refactoring-UI in BaselineOfQA>>baseline:.

Version information:

  • Version [e.g., Pharo 13.0]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant