Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full content pane is super super slow. #16787

Open
Ducasse opened this issue Jun 19, 2024 · 5 comments
Open

Full content pane is super super slow. #16787

Ducasse opened this issue Jun 19, 2024 · 5 comments

Comments

@Ducasse
Copy link
Member

Ducasse commented Jun 19, 2024

world

@Ducasse
Copy link
Member Author

Ducasse commented Jun 19, 2024

Try 'world.svg' asFileReference readStream contents
and click on full contents.... go and take a coffee

@jecisc
Copy link
Member

jecisc commented Jun 19, 2024

This is why we have Preview and Full Contents.

Since the full contents can be huge and to a lot of time to load we show only a subset at the beginning.

Maybe we could check the size of the String and above a certain size we display a warning to the user asking if he is sure he wants to display the full content?

@jecisc
Copy link
Member

jecisc commented Jun 19, 2024

I have the impression that there might be room for optimization in Rubric but since it's Morphed based, should we invest in that?

@jecisc
Copy link
Member

jecisc commented Jun 19, 2024

One performance problem I'm seing is that, while Rubric Morph is not open, each operation applied will cause a recomposition of the text. So each time Spec Morphic adapter is applying a method such as #beWrapped before opening the morph, it will still recompute all the text.

An optimization could be to not compute when the Morph is closed and compute only when we open or update. But I have no idea of how long this would take

@Ducasse
Copy link
Member Author

Ducasse commented Jun 19, 2024

Indeed I think that we should not invest now I hope that album is faster.
@plantec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants