Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiling results in ASCII format: non-monospaced font is not optimal #16766

Open
tinchodias opened this issue Jun 12, 2024 · 2 comments
Open

Comments

@tinchodias
Copy link
Contributor

The AndreasSystemProfiler class offers very convenient API in class-side to profile. The profiler results tree is printed with ASCII lines between sibling nodes, to help reading it. IMHO this is good, but monospaced font would help even more. As it happens with "ASCII art" in general.

This also happens in the "Full Report" tab of the Time Profiler GUI (and this is Pharo 13 but also in previous versions):

Steps to reproduce A

  1. Evaluate AndreasSystemProfiler spyFor: 1
  2. The result is presented in a window with sans-serif non monospaced font.

Steps to reproduce B

  1. Click on World Menu -> Debug -> Start profiling all Processes
  2. move the cursor to top, to conclude profiling and see the results in a nice GUI.
  3. Click on the "Full Report" tab

Screen captures

Case A

Current... non-monospaced:
SpyNonMono

My idea... make it monospaced:
SpyMonospaced

Case B

The "Full Report" tab of the Time Profiler GUI would benefit from monospaced font too:
Screenshot 2024-06-12 at 12 26 34

@tinchodias
Copy link
Contributor Author

For the case of AndreasSystemProfiler API, it is opened this way:

doReport
	"Report the results of this profiler run"
	UIManager default edit: self report label: 'Spy Results'

maybe monospaced font can be set here.

@tinchodias
Copy link
Contributor Author

However, it would be great that doReport opens a variant of the 'Time profiler' GUI.

In other words, I see as an alternative to my original comment that after evaluation of AndreasSystemProfiler spyFor: 1, the user could inspect the results in something like the Time profiler but without the button bar and code editor panel on top:

Screenshot 2024-06-12 at 12 54 22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant