PhanUndeclaredThis when newThis assigned to closure

[toddmazierski]

Hello. I'd like to report what I understand to be a false positive in Phan. It occurs when a newThis is assigned to a Closure. The message from Phan is PhanUndeclaredThis Variable $this is undeclared. Thank you.

Example

<?php

class NewThis
{
    public $foo = 'bar';
}

$newThis = new NewThis();

$closure = function () {
    return $this->foo; // PhanUndeclaredThis Variable $this is undeclared
};

var_dump(
    $closure->call($newThis) // prints "bar"
);

Example in Phan Demo

[MatmaRex]

I'm not a maintainer here (I was just filing my own bug and looked out of curiosity), but this seems like the expected behavior to me. You can annotate the closure with /** @phan-closure-scope NewThis */ to avoid the warning. https://github.com/phan/phan/wiki/Annotating-Your-Source-Code#phan-closure-scope

Demo:
https://phan.github.io/demo/?code=%3C%3Fphp%0A%0Aclass+NewThis%0A{%0A++++public+%24foo+%3D+'bar'%3B%0A}%0A%0A%24newThis+%3D+new+NewThis()%3B%0A%0A%2F**+%40phan-closure-scope+NewThis+*%2F%0A%24closure+%3D+function+()+{%0A++++return+%24this->foo%3B%0A}%3B%0A%0Avar_dump(%0A++++%24closure->call(%24newThis)%0A)%3B