Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeprecateAliasPlugin - checkdnsrr replace by dns_check_record alias? #4798

Open
mdeweerd opened this issue Aug 29, 2023 · 1 comment · May be fixed by #4821
Open

DeprecateAliasPlugin - checkdnsrr replace by dns_check_record alias? #4798

mdeweerd opened this issue Aug 29, 2023 · 1 comment · May be fixed by #4821

Comments

@mdeweerd
Copy link

The purpose of the DeprecateAliasPlugin seems to be to avoid aliases, but there seem to be some exceptions as for checkdnsrr.

According to https://www.php.net/manual/en/function.dns-check-record.php, dns_check_record is the alias.

phan/.phan/plugins/DeprecateAliasPlugin.php

Line 297 in 93c1c28

'checkdnsrr' => 'dns_check_record',

@stevegrunwell
Copy link

Similarly, getmxrr() (canonical) and dns_get_mx() (alias) are flipped:

phan/.phan/plugins/DeprecateAliasPlugin.php

Line 300 in 93c1c28

'getmxrr' => 'dns_get_mx',

@stevegrunwell stevegrunwell linked a pull request Nov 30, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Invert alias => canonical relationship for dns_check_record and dns_get_mx stevegrunwell/phan
2 participants
@stevegrunwell @mdeweerd