Updated with embed tag for non image-video #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| { | ||
| thumb: 'https://i-kinhdoanh.vnecdn.net/2018/06/18/1-1529296929_680x0.jpg', | ||
| src: 'https://i-kinhdoanh.vnecdn.net/2018/06/18/1-1529296929_680x0.jpg', | ||
| src: 'https://sandbox.anmup.online/storage/post/f7177163c833dff4b38fc8d2872f1ec6/qfxcinemas-ticket.pdf', |
There was a problem hiding this comment.
This link asks me for a password.
There was a problem hiding this comment.
Please use a public link
imcvampire
reviewed
Jul 7, 2020
| @@ -29,15 +29,15 @@ | |||
| name="fade" | |||
| > | |||
| <img | |||
| v-if="media[select].type !== 'video'" | |||
| v-if="/image/.test(media[select].type)" | |||
There was a problem hiding this comment.
Suggested change
| v-if="/image/.test(media[select].type)" | |
| v-if="media[select].type === "image"" |
imcvampire
reviewed
Jul 7, 2020
| :key="media[select].src" | ||
| :src="media[select].src" | ||
| :srcset="media[select].srcset || ''" | ||
| class="vue-lb-modal-image" | ||
| :alt="media[select].caption" | ||
| > | ||
| <video | ||
| v-else | ||
| v-else-if="media[select].type == 'video'" |
There was a problem hiding this comment.
Suggested change
| v-else-if="media[select].type == 'video'" | |
| v-else-if="media[select].type === 'video'" |
imcvampire
reviewed
Jul 7, 2020
| @@ -105,7 +114,7 @@ | |||
| @click.stop="showImage(index)" | |||
| > | |||
| <slot | |||
| v-if="image.type" | |||
| v-if="image.type=='video'" | |||
There was a problem hiding this comment.
Suggested change
| v-if="image.type=='video'" | |
| v-if="image.type === 'video'" |
imcvampire
reviewed
Jul 7, 2020
| }, | ||
| { | ||
| thumb: 'https://i-kinhdoanh.vnecdn.net/2018/06/18/1-1529296929_680x0.jpg', | ||
| src: 'https://i-kinhdoanh.vnecdn.net/2018/06/18/1-1529296929_680x0.jpg', | ||
| src: 'https://sandbox.anmup.online/storage/post/f7177163c833dff4b38fc8d2872f1ec6/qfxcinemas-ticket.pdf', |
There was a problem hiding this comment.
Please use a public link
| @@ -17,10 +17,11 @@ const media = [ | |||
| thumb: 'https://s3-us-west-1.amazonaws.com/powr/defaults/image-slider2.jpg', | |||
| src: 'https://s3-us-west-1.amazonaws.com/powr/defaults/image-slider2.jpg', | |||
| caption: '<h4>Elephant</h4>', | |||
| type: 'image/jpg' | |||
There was a problem hiding this comment.
Suggested change
| type: 'image/jpg' | |
| type: 'image' |
Is jpg really need?
There was a problem hiding this comment.
No it's not, this is not mime type, type is used by the lightbox to determine how to show the media.
|
@realanmup Please update the documentation on |
imcvampire
changed the title
imcvampire
changed the title
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this feature so i've updated this one. It doesn't break any thing else.