Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce clutter in gembased theme #85

Open
4 of 8 tasks
peterdesmet opened this issue Apr 30, 2023 · 0 comments
Open
4 of 8 tasks

Reduce clutter in gembased theme #85

peterdesmet opened this issue Apr 30, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@peterdesmet
Copy link
Owner

peterdesmet commented Apr 30, 2023

petridish can now be installed as a gem (see #84). I used the default spec.files

spec.files = `git ls-files -z`.split("\x0").select { |f| f.match(%r!^(assets|_data|_layouts|_includes|_sass|LICENSE|README|_config\.yml)!i) }

But that results in quite a lot of files, resulting a fresh site that looks like this:

Your-awesome-title

What we should have:

  • assets: keep, required for fonts, font-awesome, javascript, etc. Is all neatly wrapped in assets/theme subdir
  • _data: maybe it's not necessary to already have a header, footer?
  • _layouts: keep
  • _includes: keep
  • _sass: keep
  • LICENSE: keep?
  • README: keep>
  • _config.yml: likely remove, I don't think fallbacks are useful here

This is what minima has:

https://github.com/pages-themes/minimal/blob/master/jekyll-theme-minimal.gemspec#LL13C19-L13C50

@peterdesmet peterdesmet added the enhancement New feature or request label Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant