Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping Detection process invokes the error toast #24

Open
petargyurov opened this issue Jan 29, 2021 · 1 comment
Open

Stopping Detection process invokes the error toast #24

petargyurov opened this issue Jan 29, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@petargyurov
Copy link
Owner

Describe the bug
When detection is running and users press the Stop button, the error toast shows up.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Detection
  2. Start process
  3. Wait for Stop button to become active
  4. Press Stop button
  5. Observe error toast

Expected behavior
To stop the detection process without errors

Screenshots
N/A

System Information (please complete the following information):

  • OS: Windows
  • Version: 10

Additional context
The error message is null. It is probably something to do with how we handle stderr output from the backend.

@petargyurov petargyurov added the bug Something isn't working label Jan 29, 2021
@petargyurov petargyurov self-assigned this Jan 29, 2021
@petargyurov petargyurov added this to To do in 0.0.1 Release via automation Jan 29, 2021
@petargyurov petargyurov moved this from To do to In progress in 0.0.1 Release Feb 1, 2021
@petargyurov
Copy link
Owner Author

We need a graceful way of handling the killing of the child process. I suspect that instead of killing it from the parent process, we could send a signal that is handled in the Python program and shuts down itself gracefully.

Related to #13

@petargyurov petargyurov moved this from In progress to To do in 0.0.1 Release Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

1 participant