-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unit Tests for initialize() / Passing in robot model to initialize() is broken #71
Comments
I think we were right to remove the I'd prefer to either: (1) remove the Thoughts? |
I recently faced a similar issue and ended up going the other way on this parameter, largely because: (a) changing the (b) because we are moving away from |
Yes I can understand the difficulties of supporting both an xml and a urdf. Perhaps as HERBpy is for HERB, then it only needs to support one or the other. I made a WAMpy package which is like PR2py in that it can only load an xml, but incorporates some newer code changes from HERBpy. So that's how I found this problem. |
herb.py defines an initialize() function which allows you to optionally pass in the filename of a robot model.
However this is ignored, it looks like it got broken in this commit:
326eed5
The text was updated successfully, but these errors were encountered: