Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block TSR library's place and place_on should be renamed. #118

Open
gilwoolee opened this issue Dec 2, 2016 · 1 comment
Open

Block TSR library's place and place_on should be renamed. #118

gilwoolee opened this issue Dec 2, 2016 · 1 comment
Assignees

Comments

@gilwoolee
Copy link
Contributor

While reviewing for personalrobotics/magi#2, I realized that block tsr library has 'place' and 'place_on' tsrs, and it's 'place_on' serves as 'place' in many other object tsrs. For consistency across tsrs (so that same tsr name can be used for motion planning across multiple objects), 'place' should be changed to something like 'place_at' and 'place_on' should be changed to 'place'.

@vinitha910
Copy link

I renamed 'place' to 'place_at' and 'place_on' to 'place'. The changes are in block.py in the feature/MoveUntilTouch branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants