Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need flag to disable baking #108

Open
Shushman opened this issue Aug 31, 2016 · 3 comments
Open

Need flag to disable baking #108

Shushman opened this issue Aug 31, 2016 · 3 comments

Comments

@Shushman
Copy link
Contributor

Planning would not raise proper failure exception if baked is turned on.

@cdellin
Copy link
Contributor

cdellin commented Aug 31, 2016

What does this mean? What error are you seeing? HerbPy should already initialize its local robot_checker_factory member appropriately depending on the capabilities of the current collision checker (see here).

@gilwoolee
Copy link
Contributor

Oh, sorry. I did not write a good description of what I meant. We would like to see something like CollisionPlanningError during planning, and we were not seeing it when running with --baked. I think @mkoval said he discussed it with you and discovered what was going on; I forgot what it was. @mkoval Could you add to this?

@cdellin
Copy link
Contributor

cdellin commented Sep 1, 2016

Sounds good ... I was just trying to parse the original issue report. Yes, I chatted with @mkoval yesterday about this, and currently the baked checker does not correctly fill out the CollisionReport object when a collision is found (detailing which particular geometries caused the free check to fail). But in any case, the code should still correctly raise a CollisionPlanningError (see here). So if you're not seeing the exception being raised correctly, that's a different bug than the report not being filled out correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants