-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle payloads with large number of files changed #179
Comments
Should this be tackled with a full fledged task queue? Or by just using an async function? |
Hey Shubham! Thank you for the interest! Even if task queue seems like a good way to go, it might be overkill here. An async function should be sufficient for most of the cases. I can not think of a drawback. |
@tushar5526 We might work on making pep8speaks async, I can be a major rework, Also thinking of using fastapi as an ASGI. |
Related issue: #178
In PR where 100s of files are changed, there is a possibility the request will timeout. Since, the bot makes a comment, the GitHub Payload can be responded immediately. The lint job and commenting on PR can be done asynchronously.
The text was updated successfully, but these errors were encountered: