-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable support to find protobin files from jars #24
Comments
@krmahadevan please, thanks! |
@krmahadevan Please post your changes. I could use this as well |
@thinkerou - I have raised a PR that adds support for loading protobin files from CLASSPATH @ericdriggs - My bad for the insane delay. Somehow I lost track of this. Hope the PR gets merged and you can use the changeset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current implementation of this library basically expects to find the
.protobin
in the file system. This is fine if the number of proto files are less, but when this count starts increasing the code generator which translates.proto
to.java
basically takes a lot of time and as such one would want these to be part of a separate Maven/Gradle module, which comes in as a dependency.Now the problem here is that
karate-grpc
is not aware of the.protobin
that can be embedded in the proto jar.I have solved this in an internal fork of this codebase, but I was wondering if you are open to basically accomodating that here so that I dont have to maintain my own copy.
@thinkerou - Let me know what you think and I can try and raise a PR that enables this support.
The text was updated successfully, but these errors were encountered: