Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: v2 Fetch config file internally without actions/checkout #447

Closed
peaceiris opened this issue Jun 17, 2021 · 4 comments · Fixed by #489
Closed

proposal: v2 Fetch config file internally without actions/checkout #447

peaceiris opened this issue Jun 17, 2021 · 4 comments · Fixed by #489
Assignees
@peaceiris
Labels
documentation Improvements or additions to documentation enhancement New feature or request proposal
Milestone
v2.0.0

Comments

@peaceiris
Copy link
Owner

peaceiris commented Jun 17, 2021 •
edited

Is your feature request related to a problem? Please describe.

  • Fetch the config file at config_file from the remote repository.

v2 Workflow

name: Label Commenter

on:
  issues:
    types:
      - labeled
      - unlabeled
  pull_request_target:
    types:
      - labeled
      - unlabeled

permissions:
  contents: read
  issues: write
  pull-requests: write

jobs:
  comment:
    runs-on: ubuntu-20.04
    steps:
      - name: Label Commenter
        uses: peaceiris/actions-label-commenter@v2
#       with:
#         config_file: '.github/label-commenter-config.yml'
- - uses: actions/checkout@v2

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@peaceiris peaceiris self-assigned this Jun 17, 2021
@github-actions
Copy link
Contributor

Hi, there.

Thank you @peaceiris for suggesting this.

This is an automated comment created by the peaceiris/actions-label-commenter. Responding to the bot or mentioning it won't have any effect.

@peaceiris peaceiris changed the title proposal: Fetch config file internally proposal: v2 Fetch config file internally Jun 17, 2021
@peaceiris peaceiris changed the title proposal: v2 Fetch config file internally proposal: Fetch config file internally Jun 17, 2021
@peaceiris
Copy link
Owner Author

peaceiris commented Jun 17, 2021 •
edited

@Andre601 What do you think about this change? Any other ideas?

@Andre601
Copy link
Contributor

No idea

@peaceiris peaceiris changed the title proposal: Fetch config file internally proposal: Fetch config file internally without actions/checkout Jun 17, 2021
@peaceiris peaceiris added enhancement New feature or request documentation Improvements or additions to documentation labels Jun 18, 2021
@github-actions
Copy link
Contributor

Hi, there.

Thank you for suggesting documentation improvement.

This is an automated comment created by the peaceiris/actions-label-commenter. Responding to the bot or mentioning it won't have any effect.

@peaceiris peaceiris changed the title proposal: Fetch config file internally without actions/checkout proposal: v2 Fetch config file internally without actions/checkout Jun 18, 2021
@peaceiris peaceiris pinned this issue Jul 11, 2021
@peaceiris peaceiris added this to the v2 milestone Jul 31, 2021
@peaceiris peaceiris changed the title proposal: v2 Fetch config file internally without actions/checkout proposal: Fetch config file internally without actions/checkout Aug 8, 2021
@peaceiris peaceiris modified the milestones: v2.0.0, v1.11.0 Aug 8, 2021
@peaceiris peaceiris changed the title proposal: Fetch config file internally without actions/checkout proposal: v2 Fetch config file internally without actions/checkout Aug 8, 2021
@peaceiris peaceiris mentioned this issue Aug 16, 2021
Merged
peaceiris added a commit that referenced this issue Sep 4, 2021
@peaceiris
feat: Fetch config file internally without actions/checkout (#489)
d5ef6e2 
Close #447

- Fetch config file internally without actions/checkout
- Comment body placeholders:
	- Add `{{ owner }}` and `{{ repo }}`
	- Deprecate `{{ (issue|pull_request|discussion).user.login }}` and `{{ sender.login }}`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peaceiris peaceiris

Labels
documentation Improvements or additions to documentation enhancement New feature or request proposal
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

feat: Fetch config file internally without actions/checkout peaceiris/actions-label-commenter
2 participants
@Andre601 @peaceiris