-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: default the github_token input to ${{ github.token }} #309
Comments
Thank you for suggesting this. When I found this feature at actions/checkout a few months ago, other official actions were still using an empty token input so I ignored to apply it to this action. I thought that it was friendly to notify users that this action will use a built-in token. Today, only 3 official actions are using the Using the
Using an empty token input:
Personally, I think the time for using the OK. I will work on this. Note that we have some considerations for using the approach. In this action, we need to manage the order of auth tokens and the behavior on fork repositories. |
Is your feature request related to a problem? Please describe
Forcing users to add
github_token: ${{ secrets.GITHUB_TOKEN }}
adds unnecessary boilerplate, since its possible to extract this token in theaction.yml
file (see here for an example).Describe the solution you'd like
Update the
action.yml
file to default thegithub_token
input to${{ github.token }}
, then if users want to use a personal access token or deploy key instead they can set those inputs to override it.The text was updated successfully, but these errors were encountered: