Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change colors to match preview of native dark mode #139

Open
pbaity opened this issue May 17, 2021 · 5 comments
Open

Change colors to match preview of native dark mode #139

pbaity opened this issue May 17, 2021 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@pbaity
Copy link
Owner

pbaity commented May 17, 2021

@fdellwing and a few others of us talked previously (see this comment and following) about improving the colors and contrast of the dark theme. I think this is an excellent idea and we agreed a good starting point would be to emulate the colors of the sample native dark theme shared by the Rocket.Chat team:

image

image

image

There's no rule stipulating we need to copy these exactly, but whoever wants to pick up this issue can start with these colors and see how the community likes your changes.

@pbaity pbaity added enhancement New feature or request help wanted Extra attention is needed labels May 17, 2021
@pbaity
Copy link
Owner Author

pbaity commented May 17, 2021

@fdellwing Do you still plan on working on this? If not that's fine, just checking in.

@fdellwing
Copy link
Contributor

I already started with a few basics, but I have very little time atm for this at work. Will likely take another 3-4 weeks until I have something to present.

@pbaity
Copy link
Owner Author

pbaity commented May 18, 2021

Great, thanks for working on it, and no rush at all - when you feel like you have enough to share, feel free to open a WIP PR and I can do what I can to test and assist.

@pbaity pbaity pinned this issue Feb 28, 2022
@ae5960e8-a6fc-491f-b252-898ecf59af95

I'm in no rush for new colours, but this looks very nice. Looking forward to it.

@chotaire
Copy link
Contributor

chotaire commented Sep 7, 2022

I did that a year ago or so. I will see if I can find some time to rebase and merge, then send pull requests. I wish the day had 100 hours.

@pbaity pbaity unpinned this issue Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants