Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for appium MobileBy locator types. Cannot find mobile elements by accessibility id. #362

Open
elhuang opened this issue Jun 6, 2017 · 1 comment

Comments

@elhuang
Copy link
Contributor

elhuang commented Jun 6, 2017

SeLion Version

2.0.0-SNAPSHOT

Component

SeLion & SeLion-appium-provider

Expected Behavior

SeLion platform WebElements to be located via appium MobileBy types.

Actual Behavior

SeLion platform WebElements cannot be located by appium MobileBy types.

Steps to Reproduce

The bridge drivers allows findElementBy(By by) override, however limitation still exists on the set of By subclasses that can be passed in. HtmlElementUtils.resolveByType(String locator) cannot be overridden.

https://github.com/paypal/SeLion/blob/develop/client/src/main/java/com/paypal/selion/platform/mobile/ios/UIAElement.java#L67
https://github.com/paypal/SeLion/blob/develop/client/src/main/java/com/paypal/selion/platform/mobile/android/UiObject.java#L50

Proposal:

  1. Add By resolveByType(String locator); method definition in SeLionAndroidBridgeDriver and SeLionIOSBridgeDriver

  2. Appium ios/android providers can resolve MobileBy types in addition to using existing HtmlElementUtils.

  3. Other providers can continue leveraging HtmlElementUtils.

@mach6
Copy link
Contributor

mach6 commented Jun 7, 2017

@elhuang Thanks for filing this. I love it when an issue is submitted with a proposal -- even more when it is followed up with a PR. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants