Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid self healing should cleanup temp files left by Selion or browsers. #267

Open
sebady opened this issue Mar 30, 2016 · 4 comments
Open

Comments

@sebady
Copy link

sebady commented Mar 30, 2016

Grid node self healing should cleanup /tmp files left upon browser, node shutdown.
Some example files in /tmp are directories with uuid names, anonymous webdriver profiles etc.

256ed1f9-8aae-4b07-bf33-06bf1a52786f/
. . .
anonymous4623780548331041862webdriver-profile/
..

@mach6
Copy link
Contributor

mach6 commented Mar 30, 2016

I'm not sure I agree that this should be a capability of the SeLion Grid "self healing".. How would it identify a file in /tmp that is left over by Selenium, FFDriver, other grid forked processes from one that is not? This should be the function of a maintenance script/activity which is run out of band.

@sebady
Copy link
Author

sebady commented Mar 30, 2016

The self healing is fully aware of when the browsers / tests are running and therefore is the ideal place to cleanup these tmp files that are related to browsers.

@mach6
Copy link
Contributor

mach6 commented Mar 30, 2016

Okay, yes it knows when/what browsers are launched, but I don't see it. How do you map to the correct files in /tmp? Are you proposing we monitor /tmp for changes with each browser invocation? Is there an API that tells us which/where the temp profile exists so we can delete it?

@sebady
Copy link
Author

sebady commented Mar 30, 2016

You can monitor /tmp but I think a simpler cleanup process is possible. Wait till all tests have finished/stopped and browsers terminated during self healing then remove these directories:

/tmp/anonymous*webdriver-profile

Or simply call:
TemporaryFilesystem.getDefaultTmpFS().deleteTemporaryFiles()

The main disadvantage here is this assume(s) one SeLion node process is running.

@mach6 mach6 added this to the 1.2.0 milestone Jul 20, 2016
@mach6 mach6 modified the milestones: 2.0.0, 1.2.0 Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants