Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peak detection fails for high DC levels #103

Open
josueportiz opened this issue Mar 20, 2023 · 2 comments
Open

Peak detection fails for high DC levels #103

josueportiz opened this issue Mar 20, 2023 · 2 comments
Assignees

Comments

@josueportiz
Copy link

In fit_peaks(), the moving average values to test list (ma_perc_list) starts at 5 %. Signals with high DC values related to the AC component (e.g. some PPG signals) add a high value to test so that the starting 5% leads to moving average values higher than any of the peaks of the signal.

Please, consider add fine grained values to the ma_perc_list: 0, 1, 2, 3, 4 %. Otherwise it does not work.

@paulvangentcom
Copy link
Owner

Thanks for the suggestion, I will put it on the list for the next version. Currently picking up heartpy again.

@SahebehDadboud
Copy link

SahebehDadboud commented Apr 4, 2023

@paulvangentcom that's one of the reasons I can't use Hearpy package as a built-in module, so I had to clone the project. If you add ma_perc_list as a parameter to the function (which I did already), it would be much more beneficial. Currently I had to divide the original ma_perc_list by 10 to let rolling mean find the peaks in our device(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants