-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make moment_match work natively with cmdstanr #1556
Comments
FYI (if you didn't already know) as of |
Thank you! I didn't know but I am sure this will be very helpful! |
A solution to this could also help with what @topipa and I are trying to do with iwmm, see topipa/iwmm/issues/4 |
I don't think I will be able to implement this feature in brms 2.21. More like in 3.0. The reason is that using moment matching with cmdstanr requires the cmdstanr objects, which are currently not stored but converted to rstan objects. In brms 3.0 we should change this policy by always storing the object provided by the backend used to fit the model. This comes with quite a few other necessary changes so I don't think I can make this possible now. |
Currently, brms switches to rstan backend to make moment matching happen in
loo()
. However, withlog_prob
and friends now being available in cmdstanr too, models fit with cmdstanr no longer have to be recompiled in rstan. This is particularily relevant as moment matching regularily crashes the R session when using rstan 2.26 or 2.32.The text was updated successfully, but these errors were encountered: