Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark theme for website #297

Open
ghost opened this issue Feb 17, 2020 · 5 comments · May be fixed by #358
Open

Dark theme for website #297

ghost opened this issue Feb 17, 2020 · 5 comments · May be fixed by #358
Labels
good first issue

Comments

@ghost
Copy link

ghost commented Feb 17, 2020 •
edited by ghost

No description provided.

@ghost ghost changed the title Dark theme for websiteDark theme for website Dark theme for website Feb 17, 2020
@pastelsky
Copy link
Owner

Happy to take PRs for this. This is something that I've been thinking of implementing, but haven't had the time.

@prabuw
Copy link

prabuw commented Jun 6, 2020

Hey @pastelsky, I'm interested in working on this. Do you have any guidance? I can have a go and we can discuss in a PR.

@prabuw prabuw linked a pull request Jun 10, 2020 that will close this issue
Open
@prabuw
Copy link

prabuw commented Jun 10, 2020 •
edited

I've raised a PR #358 as a first attempt. Not sure how I can link this issue to the PR other than in the comment here.

Looking for some feedback if someone wants to review it. 😄

@ghost
Copy link
Author

ghost commented Jun 11, 2020

Write closes #297 in description

@himankpathak
Copy link

@pastelsky Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable dark theme prabuw/bundlephobia
3 participants
@prabuw @pastelsky @himankpathak