Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress hex animation blocks render on mount #234

Open
mvasigh opened this issue Oct 27, 2019 · 1 comment · May be fixed by #235
Open

Progress hex animation blocks render on mount #234

mvasigh opened this issue Oct 27, 2019 · 1 comment · May be fixed by #235
Labels
bug

Comments

@mvasigh
Copy link

mvasigh commented Oct 27, 2019

Describe the bug
The mounting sequence for the Progress Hex blocks the main thread for 1-10 seconds due to anime timeline add method. This especially impacts mobile users as the user interface completely freezes for 2+ seconds (on Chrome for Android, running on Google Pixel XL).

To Reproduce

  1. Go to home page
  2. Search for a package, immediately try to use the UI before loading indicator mounts (i.e. scroll)

For debugging/testing:

  1. Set profiler to record.
  2. Perform the above steps.

Screen Shot 2019-10-27 at 8 59 28 AM

Expected behavior
Progress indicator should not block render or freeze the UI.
@mvasigh mvasigh added the bug label Oct 27, 2019
@mvasigh
Copy link
Author

mvasigh commented Oct 27, 2019

Opening a PR for this :) just wanted to open an issue for tracking as well

@mvasigh mvasigh linked a pull request Oct 27, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ProgressHex mount blocking render for several seconds mvasigh/bundlephobia
1 participant
@mvasigh