Skip to content
This repository has been archived by the owner on Apr 20, 2021. It is now read-only.

Mosby #29

Open
BraunreutherA opened this issue Oct 29, 2016 · 2 comments
Open

Mosby #29

BraunreutherA opened this issue Oct 29, 2016 · 2 comments

Comments

@BraunreutherA
Copy link

BraunreutherA commented Oct 29, 2016

Hi,

in the documentation you wrote about integrating the mosby library as a plugin. Have you done so already? I started doing it but having some trouble to get it done.
Furthermore I'd like to start a repo with common plugins - If you're interested, I would contribute them directly here.

Best
Alex

@passsy
Copy link
Owner

passsy commented Oct 29, 2016

I don't have an implementation of a mosby plugin because I'm using ThirtyInch for MVP. You can check the plugin implementation to get an idea. What are the troubles you are dealing with?

In my opinion, plugins for individual libraries should live in the repo of the library and not in the CompositeAndroid repo. As long as it's not part of the main project a separate repo is fine. Instead of a collection, create a separate repo for each plugin. It'll be easier to maintain.

If you wrote plugins I'd love to link them here in the README and build a collection.

@BraunreutherA
Copy link
Author

Thanks for your suggestions - iI think your implementaton leads me into the right direction. The problem I had was getting the presenter into the Plugin cause it gets created in the activity/fragment via dagger as injection. I could create a interfacte like the presenter provider and let the activity implement it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants