-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeouts on requests #19
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Are you guys considering adding timeouts to the requests made in the library? My understanding is that there is no timeouts in
superagent
, and therefore some requests might never end, which is something that I am seeing happening in mobile env with not a great connectivity.A possibility would be to extend the
Defaults
with a timeout, that would be applied to the request in the_request()
, and that I could override when creating the Particle object in my app:The text was updated successfully, but these errors were encountered: