Skip to content
This repository has been archived by the owner on May 12, 2020. It is now read-only.

Upgrade serialport to latest stable #229

Open
beriberikix opened this issue Nov 1, 2017 · 2 comments
Open

Upgrade serialport to latest stable #229

beriberikix opened this issue Nov 1, 2017 · 2 comments

Comments

@beriberikix
Copy link

See related particle-iot/particle-cli#390. I also noticed we're using a fork of node-serialport - do we know if we can move to the mainline version?

@suda
Copy link
Contributor

suda commented Nov 1, 2017

We're using the fork because the serialport module didn't previously work well with Electron. We could try using the latest version and seeing if it's ok now.

@beriberikix
Copy link
Author

Makes sense, thanks for the background. It looks like there are now separate, optimized builds specifically for Electron ✨

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants