Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace JwtSecret type with alloy's #8276

Closed
mattsse opened this issue May 15, 2024 · 1 comment · Fixed by #8299
Closed

replace JwtSecret type with alloy's #8276

mattsse opened this issue May 15, 2024 · 1 comment · Fixed by #8299
Labels
A-rpc Related to the RPC implementation C-debt A section of code is hard to understand or change D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented May 15, 2024

Describe the feature

alloy now has the same type, which means we can now phase out the reth type:

pub struct JwtSecret([u8; 32]);
impl JwtSecret {

we like need to change the function that reads from disk to a standalone function

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started C-debt A section of code is hard to understand or change A-rpc Related to the RPC implementation labels May 15, 2024
@quentinv72
Copy link
Contributor

I can do this. @mattsse Would it make sense to define the from_file and try_create methods in alloy directly? As opposed to creating standalone functions in reth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-debt A section of code is hard to understand or change D-good-first-issue Nice and easy! A great choice to get started
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants