-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eth
message type metrics
#8245
Labels
A-devp2p
Related to the Ethereum P2P protocol
A-networking
Related to networking in general
A-observability
Related to tracing, metrics, logs and other observability tools
C-enhancement
New feature or request
D-good-first-issue
Nice and easy! A great choice to get started
Comments
Rjected
added
C-enhancement
New feature or request
A-devp2p
Related to the Ethereum P2P protocol
A-observability
Related to tracing, metrics, logs and other observability tools
A-networking
Related to networking in general
D-good-first-issue
Nice and easy! A great choice to get started
labels
May 14, 2024
I'm interested in taking this one on but i noticed there's already a EthRequestHandlerMetrics here: reth/crates/net/network/src/metrics.rs Lines 310 to 318 in 081796b
reth/crates/net/network/src/eth_requests.rs Lines 141 to 187 in 081796b
(edit: ala f997f5a) |
yep, exactly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-devp2p
Related to the Ethereum P2P protocol
A-networking
Related to networking in general
A-observability
Related to tracing, metrics, logs and other observability tools
C-enhancement
New feature or request
D-good-first-issue
Nice and easy! A great choice to get started
Describe the feature
Even if we don't handle a certain type of request, it would be interesting to see what kinds of requests we are receiving, and in what proportion (GetReceipts, GetBlockHeaders, ...). We should add metrics for this.
This would involve introducing a new metrics type with counts for each type of
eth
message, and then increment the counts here:reth/crates/net/network/src/eth_requests.rs
Lines 236 to 258 in 081796b
Additional context
No response
The text was updated successfully, but these errors were encountered: