Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting out types into libgemini? #40

Open
aThorp96 opened this issue Jul 31, 2021 · 5 comments
Open

Splitting out types into libgemini? #40

aThorp96 opened this issue Jul 31, 2021 · 5 comments

Comments

@aThorp96
Copy link

Hello! I've been writing a small gemini client and I believe a lot of the functionality in the types directory could be used as a standalone library. Is that something that would be of interest at all?

@panicbit
Copy link
Owner

I haven't actively worked on this library in a while, so right now I can not judge wether this is reasonable or even useful, but I am open to the idea.

@panicbit
Copy link
Owner

I've had a look now and decided to try splitting the module into a separate crate.

@panicbit
Copy link
Owner

I'm not sure wether to publish this as northstar-types or gemini-types though.

@panicbit
Copy link
Owner

panicbit commented Jul 31, 2021

This also raises the question of how to do versioning. If I'd keep the types crate in this repository, it would be the easiest to manage, but it would also make it unclear how to tag releases.

@aThorp96
Copy link
Author

aThorp96 commented Aug 8, 2021

One possibility would be to use features to either import the full package or just the gemini library. That would save some compile time on the end user's end without any operational overhead (I think) on the maintainers' end-- just the initial setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants