Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow increase in timeout for webhooks #639

Open
DavidJFowler opened this issue Oct 5, 2023 · 3 comments
Open

Allow increase in timeout for webhooks #639

DavidJFowler opened this issue Oct 5, 2023 · 3 comments

Comments

@DavidJFowler
Copy link

Pre issue-raising checklist

I have already (please mark the applicable with an x):

  • [ x] Upgraded to the latest Pact Broker OR
  • [x ] Checked the CHANGELOG to see if the issue I am about to raise has been fixed

Software versions

pact-broker docker version: pactfoundation/pact-broker:2.112.0-pactbroker2.107.1

Expected behaviour

It should be possible to specify the timeout for executing a webhook in order to give services time to warm up etc.

Actual behaviour

The timeout is fixed at 15 seconds. If the webhook takes longer than this time to return a value it can get triggered multiple times in error.

@YOU54F
Copy link
Member

YOU54F commented Oct 5, 2023

Hey @DavidJFowler

You are indeed correct at it being fixed at 15 seconds

options = PactBroker::BuildHttpOptions.call(uri, disable_ssl_verification: disable_ssl_verification, cert_store: cert_store).merge(read_timeout: 15, open_timeout: 15)

would you be interested in submitting a pull request for this feature req? There is already an opt disable_ssl_verification, which is taken from the pact configuration options, so that might give you a decent pattern to follow

@DavidJFowler
Copy link
Author

would you be interested in submitting a pull request for this feature req?

@YOU54F Thanks for the reply and the hint. I'd love to submit a PR, but I'm a stranger to Ruby and I just don't have the time.

@bethesque
Copy link
Member

Good easy hacktober issue for someone who knows ruby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants