Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default maven repository #303

Open
prabhu opened this issue May 2, 2024 · 2 comments
Open

Default maven repository #303

prabhu opened this issue May 2, 2024 · 2 comments

Comments

@prabhu
Copy link

prabhu commented May 2, 2024

The default maven repository got changed as per this issue.

While working on a PR, noticed that the Remote Repository reported by maven was https://repo1.maven.org/maven2/.

Am I correct in assuming that this repository MUST get added to the purl as repository_url as per the current specification?

Some examples:

pkg:maven/com.github.javaparser/[email protected]?type=jar&repository_url=https%3A%2F%2Frepo1.maven.org%2Fmaven2%2F"

pkg:maven/org.codehaus.groovy/[email protected]?type=jar&repository_url=https%3A%2F%2Frepo1.maven.org%2Fmaven2%2F"

pkg:maven/org.codehaus.groovy/[email protected]?type=jar&repository_url=https%3A%2F%2Frepo1.maven.org%2Fmaven2%2F"
@matt-phylum
Copy link

A similar thing happened with Python in #250. It makes a mess because these repository URLs are supposed to be equivalent, but how are you supposed to know when building or comparing PURLs?

@prabhu
Copy link
Author

prabhu commented May 3, 2024

The consumer of purls could maintain a database of aliases and perform the matching. I think the spec could have less opinion. For example, purl doesn't have to assume any default repository and allow tools to always form the full values including the repository url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants