Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally using a path and naming virtual environment file #8

Open
shubidubapp opened this issue Oct 30, 2019 · 3 comments
Open

Optionally using a path and naming virtual environment file #8

shubidubapp opened this issue Oct 30, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@shubidubapp
Copy link
Contributor

There are different conventions for virtual environments.
Like creating all the virtual environments on a folder ( "~/virtualenvs/" ),
or naming the virtual environment with a leading dot ( ".../project/path/.venv" ),
right now the virtual environment is created inside the project folder with a default name "venv"

@ozanonurtek
Copy link
Owner

I didn't hear about '~/virtualenvs/' usage before therefore not sure about integrating this feature. Is it widely used?
As you know general approach for creating virtualenv(ofc it is not a rule) is creating a folder called 'venv' inside the project and that's why flask-now act like this.

@ozanonurtek ozanonurtek added good first issue Good for newcomers enhancement New feature or request labels Nov 1, 2019
@ozanonurtek ozanonurtek self-assigned this Nov 1, 2019
@shubidubapp
Copy link
Contributor Author

Well. The "~/virtualenvs" style usage is not too wide but I am sure it's something being used. But ".venv" is more widely used as virtualenvs is not something you generally upload to anywhere or share. It's pretty logical to keep it as a "hidden" folder.

At least it is surely a personal choice more than a public rule ( again it most of the time will only stay on the developers' device).

I am planning on making a pull request for the change, since it will basically be a default value with an option to change it. And it should simply be a string change. I just don't have the time right now.

@ozanonurtek
Copy link
Owner

Got it. Thaks for your contribution. Assigning this issue to you. Not closing the issue until any pr is created. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants