Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oxlint] result inconsistencies for rule no-cycle #3117

Closed
folkvir opened this issue Apr 27, 2024 · 2 comments
Closed

[oxlint] result inconsistencies for rule no-cycle #3117

folkvir opened this issue Apr 27, 2024 · 2 comments
Assignees
Labels
C-bug Category - Bug

Comments

@folkvir
Copy link

folkvir commented Apr 27, 2024

There are inconsistencies in the result of oxlint using --threads N and in the results compared to eslint.

There are two types of problems:

  • inconsistencies with the --threads option. When I use --threads 1 I get 2 results and when I use --threads 10 I get 5 results. The expected is 7 cycles; what eslint is reporting.
  • Eslint reports 7 cycles while oxlint reports only 5 of them. The 7 cycles are explained in the test repository.

Reproductible repo: https://github.com/folkvir/oxc_no-cycle_test
The cycles are explained in the README

@folkvir folkvir added the C-bug Category - Bug label Apr 27, 2024
@Boshen
Copy link
Member

Boshen commented May 1, 2024

Regarding different number of cycles comparing to eslint - I think both results are correct because a cycle is formed, the difference seems to come from a depth first or a breath first search.

I'll look into --threads next.

@Boshen
Copy link
Member

Boshen commented May 14, 2024

I can't fix the mismatch for the time being, it is a bit difficult figure out what's wrong with --threads=1.

Given that no-cycles are still being detected for all the entry files, I'm going to close this as won't fix for now.

@Boshen Boshen closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category - Bug
Projects
None yet
Development

No branches or pull requests

2 participants