Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DispatchAudit Serialization Problems #893

Merged
merged 3 commits into from
May 21, 2024

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Dec 28, 2023

Testing SerializesModels SerializesModels was unnecessary
Closes #892
Closes #891
Closes #890
Closes #895
Closes #885
I think this complicates things quite a bit.

src/Events/DispatchAudit.php Show resolved Hide resolved
src/Events/DispatchAudit.php Show resolved Hide resolved
@cangelis
Copy link

I think we should also have a test failing before the patch to ensure it really is fixed and never happening again.

@erikn69
Copy link
Contributor Author

erikn69 commented Dec 29, 2023

@cangelis test added, but i don't use sanctum, was the __sleep() problem fixed?

@anteriovieira anteriovieira merged commit 4afff44 into owen-it:master May 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment