Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LFO Process frequency values are different in the inspector and in the widget. #1521

Open
guillaumeriousat opened this issue May 15, 2024 · 3 comments

Comments

@guillaumeriousat
Copy link

The LFO process frequency values are in hertz (I empirically verified) in the widget and in some kind of strange scaling in the inspector.

I think they should be in hertz everywhere.

image

@jcelerier
Copy link
Member

So for this issue I'd like to redo the LFO process in avendish as this grants better flexibility than the previous API this was implemented with.

I had started here : https://github.com/celtera/avendish/blob/3028a955d3489795848c389e8360ea0631b35989/examples/Advanced/Utilities/LFO.hpp#L12

The current code is there :

@guillaumeriousat would you be interested in looking into this ?

@guillaumeriousat
Copy link
Author

Looking into this could be fun. How much do we need to care about compatibility with older patches ?

@jcelerier
Copy link
Member

jcelerier commented May 30, 2024

so the compatibility mechanism currently is :

  • Processes have a different UUID
  • Processes can have a "deprecated" flag. If they have this flag, the user cannot create new instances of them. But they will still be loaded in a given patch
  • So the system keeps in memory the previous versions of the process for compat with older patch, but if you create an object you always get the last version (which has a different UUID than the previous one)
  • A next step would be to have something like Ableton Live's feature which allows to upgrade a process to its new version, I have some rough draft prototypes for how to achieve this
  • For a PR it's ok to just add a new object (or continue the "LFO X" object shared previously)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

2 participants