Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate authorized quote denom in CL module #8231

Closed
czarcas7ic opened this issue May 6, 2024 · 2 comments · Fixed by #8288
Closed

chore: deprecate authorized quote denom in CL module #8231

czarcas7ic opened this issue May 6, 2024 · 2 comments · Fixed by #8288

Comments

@czarcas7ic
Copy link
Member

czarcas7ic commented May 6, 2024

v ✰ Thanks for creating an issue! ✰
☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->

Background

osmosisd q concentratedliquidity params
params:
  authorized_quote_denoms:
  - uosmo
  - ibc/27394FB092D2ECCD56123C74F36E4C1F926001CEADA9CA97EA622B25F41E5EB2
  - ibc/0CD3A0285E1341859B5E86B6AB7682F023D03E97607CCC1DC95706411D866DF7
  - ibc/498A0751C798A0D9A389AA3691123DADA57DAA4FE165D5C75894505B876BA6E4
  - ibc/4ABBEF4C8926DDDB320AE5188CFD63267ABBCEFC0583E4AE05D6E5AA2401DDAB
  - ibc/EA1D43981D5C9A1C4AAEA9C23BB1D4FA126BA9BC7020A25E0AE4AA841EA25DC5
  - ibc/D1542AA8762DB13087D8364F3EA6509FD6F009A34F00426AF9E4F9FA85CBBF1F

This param now lives in poolmanager. This old param in CL module should get removed to reduce confusion.

Suggested Design

  • Remove all old code

Acceptance Criteria

  • removed old params
  • added removal of params to migration for v2x
@deividaspetraitis
Copy link
Contributor

hey @czarcas7ic, can I give a try on this one, if that's still relevant?

@czarcas7ic
Copy link
Member Author

@deividaspetraitis yes please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants