Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tt.reshape not working properly #84

Open
vbatista73 opened this issue Jul 21, 2021 · 6 comments
Open

tt.reshape not working properly #84

vbatista73 opened this issue Jul 21, 2021 · 6 comments
Labels

Comments

@vbatista73
Copy link

y=tt.rand(2,11,3); yr=tt.reshape(y,[2,2**10]);

Error for ys=yr.round(1e-6)
Error for print(yr[1,1])

@daskol
Copy link
Collaborator

daskol commented Jul 21, 2021

It works fine for me.

In [2]: y = tt.rand(2, 11, 3)
   ...: yr = tt.reshape(y, [2, 2 ** 10])
   ...: ys = yr.round(1e-6)
   ...: print(yr[1, 1])
-6.180037546754562

Could you provide more details (at least traceback)?

@vbatista73
Copy link
Author

vbatista73 commented Jul 21, 2021 via email

@daskol
Copy link
Collaborator

daskol commented Jul 21, 2021

The issue has been already fixed. However, the fix is not published to PyPI. I guess that the preferred installation way is building from source tree. Fortunately, it could be done easily in Colab as follows.

!pip install git+https://github.com/oseledets/ttpy.git@refs/pull/87/head

As soon as #87 is merged you can drop @... suffix and run.

!pip install git+https://github.com/oseledets/ttpy.git

@oseledets Can we bump package version and upload it to PyPI?

@vbatista73
Copy link
Author

vbatista73 commented Jul 21, 2021 via email

@vbatista73
Copy link
Author

vbatista73 commented Jul 22, 2021 via email

@daskol daskol added the bug label Jul 28, 2021
@daskol
Copy link
Collaborator

daskol commented Jul 28, 2021

Confirmed. It seems like TT cores are merged incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants