Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This library should be marked as depreacated #172

Open
idish opened this issue Oct 8, 2018 · 0 comments
Open

This library should be marked as depreacated #172

idish opened this issue Oct 8, 2018 · 0 comments

Comments

@idish
Copy link

idish commented Oct 8, 2018

There's a component from android SDKs that is responsible exactly for this kind of job, the component is called BottomSheetDialog or BottomSheetDialogFragment. and is part of android.support.design since version v24.3!
After using both libraries (dialogplus and the one from the support lib). I can say that the support lib is far more robust solution, and seems to be more fluent and less laggy.

Read here: https://material.io/develop/android/components/bottom-sheet-dialog-fragment/

I advice you guys to mark this library as deprecated, so people like me won't waste their time integrating external non-relevant libraries in their projects.

Obviously, I thank you very much for the good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant