You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I'm using FormKit more and more, I found these shortcomings (in my eyes right now):
Empty Taglist
The Taglist input is designed to allow for new, user-inputted values. So it's should be quite common to start with an empty taglist when it's the users who provide the values with their input and not some backend.
However, taglists with :allow-new-values="true" and without :options still render the dropdown icon (which is useless if there are no options and if newly added values are not added to the list of options) and an ever so small yet still visible empty overlay. I think that both should be omitted in this case by default (even though there probably is a way to customize that with maybe empty sections).
Empty Colorpicker
The Colorpicker input can't be used to remove an initially given color value from the input. Like with other inputs, users should be allowed and able to remove any value they might have set in the past with the Colorpicker (as long as it's not under some sort of required validation rule, of course).
The other way around also applies: Without initial value, the Colorpicker still shows #000000 (for format="hex"). That's confusing for users as they don't know if they've actually set that value or if it's a placeholder for null.
One more thing...
When hitting Enter while the input field of the Colorpicker's popover is in focus, one submits the underlying form while the popover remains open. As a user, I'd expect the opposite: The popover closes but the form isn't submitted yet. Or am I overlooking something?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
As I'm using FormKit more and more, I found these shortcomings (in my eyes right now):
Empty Taglist
The Taglist input is designed to allow for new, user-inputted values. So it's should be quite common to start with an empty taglist when it's the users who provide the values with their input and not some backend.
However, taglists with
:allow-new-values="true"
and without:options
still render the dropdown icon (which is useless if there are no options and if newly added values are not added to the list of options) and an ever so small yet still visible empty overlay. I think that both should be omitted in this case by default (even though there probably is a way to customize that with maybe empty sections).Empty Colorpicker
The Colorpicker input can't be used to remove an initially given color value from the input. Like with other inputs, users should be allowed and able to remove any value they might have set in the past with the Colorpicker (as long as it's not under some sort of
required
validation rule, of course).The other way around also applies: Without initial value, the Colorpicker still shows
#000000
(forformat="hex"
). That's confusing for users as they don't know if they've actually set that value or if it's a placeholder fornull
.One more thing...
When hitting
Enter
while the input field of the Colorpicker's popover is in focus, one submits the underlying form while the popover remains open. As a user, I'd expect the opposite: The popover closes but the form isn't submitted yet. Or am I overlooking something?Beta Was this translation helpful? Give feedback.
All reactions